This repository has been archived by the owner on Aug 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
add docker files #45
Open
chris-tbd
wants to merge
8
commits into
TBD54566975:main
Choose a base branch
from
chris-tbd:add-docker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add docker files #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-tbd
requested review from
michaelneale,
mistermoe,
phoebe-lew,
jiyoonie9 and
kirahsapong
as code owners
May 15, 2024 17:32
leordev
reviewed
May 15, 2024
leordev
reviewed
May 15, 2024
leordev
reviewed
May 15, 2024
leordev
reviewed
May 15, 2024
leordev
reviewed
May 15, 2024
leordev
reviewed
May 15, 2024
leordev
reviewed
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition by introducing Docker setup containerizing the application! That's the first step to deploy in our infra! 🎉
I added some comments for general adjusts to be made. But they are very small and this is great!
Something that I'd add to this PR are the instructions related to running locally with Docker in the README file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on the introduction of Docker to the codebase. Docker is a tool that helps to create, deploy, and run applications by using containers. The changes include the creation of Docker-related files and configurations, as well as the addition of Docker-related scripts in the
package.json
file.Docker-related changes:
.dockerignore
: This file was created to specify files and directories that Docker should ignore when building the Docker image. It includes entries likenode_modules
,npm-debug.log
,docker-compose.yml
,.DS_Store
, and.git
.Dockerfile
: This file was added to define how to build a Docker image for the application. It specifies that the base image should be the official Node.js image, sets the working directory inside the container, copies necessary files, installs application dependencies, and downloads and installs dbmate.docker-compose.yaml
: This file was added to define and configure the application's services. It specifies the use of the latest version of the postgres image and the Node.js 20.4.0 image, sets environment variables, defines dependencies between services, and specifies commands to run..github/workflows/docker-image-publish.yml
: This file was added to define a GitHub Actions workflow that builds and publishes a Docker image whenever there's a push or pull request to themain
branch.Changes to scripts:
package.json
: Docker-related scripts were added, includingdocker:up
to start the Docker containers,docker:down
to stop the Docker containers,docker:logs
to follow the logs of the Docker containers, anddocker:build
to build the Docker images.