Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring so error causality is easier to follow #672

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

andresuribe87
Copy link
Contributor

Overview

Fixes #635

@codecov-commenter
Copy link

Codecov Report

Merging #672 (c3dda71) into main (2591f0e) will not change coverage.
The diff coverage is 8.33%.

@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage   25.49%   25.49%           
=======================================
  Files          56       56           
  Lines        6307     6307           
=======================================
  Hits         1608     1608           
  Misses       4421     4421           
  Partials      278      278           
Files Changed Coverage Δ
integration/common.go 1.30% <0.00%> (ø)
internal/keyaccess/dataintegrity.go 58.33% <0.00%> (ø)
internal/keyaccess/jwt.go 43.69% <0.00%> (ø)
internal/util/crypto.go 37.50% <0.00%> (ø)
pkg/server/router/credential.go 11.93% <0.00%> (ø)
pkg/server/router/issuance.go 0.00% <0.00%> (ø)
pkg/server/router/keystore.go 10.25% <0.00%> (ø)
pkg/server/router/manifest.go 7.75% <0.00%> (ø)
pkg/server/router/presentation.go 2.38% <0.00%> (ø)
pkg/server/router/schema.go 6.72% <0.00%> (ø)
... and 11 more

@andresuribe87
Copy link
Contributor Author

@nitro-neal or @decentralgabe could I get a stamp here plz?

@andresuribe87 andresuribe87 merged commit 79cfb8b into TBD54566975:main Oct 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the word "error" (and other negatives) from error.Wrap messages
3 participants