Retrieve pagination parameters from the correct location #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresuribe87
requested review from
decentralgabe and
nitro-neal
as code owners
decentralgabe
approved these changes
Aug 2, 2023
pkg/server/pagination/pagination.go
Outdated
| @@ -31,7 +31,7 @@ const ( | |||
| // execution is responded to using the passed in gin.Context. The return value corresponds to whether there was an | |||
| // error within the function. | |||
| func ParsePaginationParams(c *gin.Context, pageRequest *PageRequest) bool { | |||
There was a problem hiding this comment.
rename to ParsePaginationQueryValues?
There was a problem hiding this comment.
Done in 80a4239
Codecov Report
@@ Coverage Diff @@
## main #627 +/- ##
=======================================
Coverage 26.64% 26.64%
=======================================
Files 55 55
Lines 5855 5855
=======================================
Hits 1560 1560
Misses 4023 4023
Partials 272 272
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #626
Description
Parameters are before the URL path (i.e. before the
?). Query parameters come after.How Has This Been Tested?
Tests were updated to fail before changes were made. And are passing after the changes were made.