Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete unused console FSM stuff #3329

Merged
merged 1 commit into from
Nov 5, 2024
Merged

chore: delete unused console FSM stuff #3329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions backend/controller/console/console.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,8 +805,6 @@ func eventDALToProto(event timeline.Event) *pbconsole.Event {
asyncEventType = pbconsole.AsyncExecuteEventType_ASYNC_EXECUTE_EVENT_TYPE_UNKNOWN
case timeline.AsyncExecuteEventTypeCron:
asyncEventType = pbconsole.AsyncExecuteEventType_ASYNC_EXECUTE_EVENT_TYPE_CRON
case timeline.AsyncExecuteEventTypeFSM:
asyncEventType = pbconsole.AsyncExecuteEventType_ASYNC_EXECUTE_EVENT_TYPE_FSM
case timeline.AsyncExecuteEventTypePubSub:
asyncEventType = pbconsole.AsyncExecuteEventType_ASYNC_EXECUTE_EVENT_TYPE_PUBSUB
}
Expand Down
1 change: 0 additions & 1 deletion backend/controller/timeline/events_async.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ type AsyncExecuteEventType string
const (
AsyncExecuteEventTypeUnkown AsyncExecuteEventType = "unknown"
AsyncExecuteEventTypeCron AsyncExecuteEventType = "cron"
AsyncExecuteEventTypeFSM AsyncExecuteEventType = "fsm"
AsyncExecuteEventTypePubSub AsyncExecuteEventType = "pubsub"
)

Expand Down
107 changes: 51 additions & 56 deletions backend/protos/xyz/block/ftl/v1/console/console.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions backend/protos/xyz/block/ftl/v1/console/console.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ enum EventType {
enum AsyncExecuteEventType {
ASYNC_EXECUTE_EVENT_TYPE_UNKNOWN = 0;
ASYNC_EXECUTE_EVENT_TYPE_CRON = 1;
ASYNC_EXECUTE_EVENT_TYPE_FSM = 2;
ASYNC_EXECUTE_EVENT_TYPE_PUBSUB = 3;
ASYNC_EXECUTE_EVENT_TYPE_PUBSUB = 2;
}

enum LogLevel {
Expand Down
4 changes: 1 addition & 3 deletions frontend/console/src/features/timeline/timeline.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,8 @@ export const asyncEventTypeString = (type: AsyncExecuteEventType) => {
switch (type) {
case AsyncExecuteEventType.CRON:
return 'cron'
case AsyncExecuteEventType.FSM:
return 'FSM'
case AsyncExecuteEventType.PUBSUB:
return 'PubSub'
return 'pubsub'
default:
return 'unknown'
}
Expand Down
12 changes: 3 additions & 9 deletions frontend/console/src/protos/xyz/block/ftl/v1/console/console_pb.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading