Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: schema diff missing output #3032

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: schema diff missing output #3032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/cli/cmd_schema_diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"github.com/TBD54566975/ftl/internal/projectconfig"
"github.com/TBD54566975/ftl/internal/rpc"
"github.com/TBD54566975/ftl/internal/schema"
"github.com/TBD54566975/ftl/internal/terminal"
"github.com/TBD54566975/ftl/internal/watch"
)

Expand Down Expand Up @@ -78,6 +79,9 @@ func (d *schemaDiffCmd) Run(ctx context.Context, currentURL *url.URL, projConfig

// Similar to the `diff` command, exit with 1 if there are differences.
if diff != "" {
// Unfortunately we need to close the terminal before exit to make sure the output is printed
// This is only applicable when we explicitly call os.Exit
terminal.FromContext(ctx).Close()
os.Exit(1)
}

Expand Down
Loading