feat: run tests on different port #2578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
added
the
run-all
stuartwdouglas
force-pushed
the
stuartwdouglas/2577
branch
5 times, most recently
from
8143b1e
to
78d2844
Compare
stuartwdouglas
requested review from
a team and
jonathanj-square
and removed request for
a team
alecthomas
reviewed
Sep 5, 2024
internal/integration/actions.go
Outdated
| @@ -170,7 +172,7 @@ func Exec(cmd string, args ...string) Action { | |||
| func ExecWithExpectedOutput(want string, cmd string, args ...string) Action { | |||
| return func(t testing.TB, ic TestContext) { | |||
| Infof("Executing: %s %s", cmd, shellquote.Join(args...)) | |||
| output, err := ftlexec.Capture(ic, ic.workDir, cmd, args...) | |||
| output, err := ftlexec.CaptureWithEnv(ic, ic.workDir, cmd, []string{"FTL_ENDPOINT=http://127.0.0.1:" + TestPort}, args...) | |||
There was a problem hiding this comment.
Rather than having to do this, let's just set FTL_ENDPOINT in Run() with t.Setenv() then it's just set everywhere by default.
stuartwdouglas
force-pushed
the
stuartwdouglas/2577
branch
2 times, most recently
from
afd8805
to
844229f
Compare
alecthomas
reviewed
Sep 6, 2024
This should stop tests from interferring with ftl dev fixes #2577
stuartwdouglas
force-pushed
the
stuartwdouglas/2577
branch
from
844229f
to
0927770
Compare
|
closing for now, as it is not a priority and turned out to require more time than I expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should stop tests from interferring with ftl dev
fixes #2577