refactor: move configuration manager, routers and providers into their own packages #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
added
the
run-all
alecthomas
requested review from
a team and
stuartwdouglas
and removed request for
a team
alecthomas
force-pushed
the
aat/configuration-refactor
branch
from
0aec595
to
72488bc
Compare
|
@alecthomas yep, they're intertwined currently 👍 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alecthomas
force-pushed
the
aat/configuration-refactor
branch
2 times, most recently
from
281d7fb
to
d33cb2d
Compare
alecthomas
removed
the
run-all
alecthomas
force-pushed
the
aat/configuration-refactor
branch
3 times, most recently
from
b1af5cb
to
77b25a0
Compare
…r own packages @matt2e the ASM tests use the internals of the manager et al, and I couldn't figure out an easy way to resolve that. I'll file a ticket for us to followup on this later.
alecthomas
force-pushed
the
aat/configuration-refactor
branch
from
77b25a0
to
bea517b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matt2e the ASM tests use the internals of the manager et al, and I couldn't figure out an easy way to resolve that. I'll file a ticket for us to followup on this later.