fix: publishing vscode extension #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
requested review from
a team,
matt2e and
deniseli
and removed request for
a team
deniseli
approved these changes
Aug 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Can you add a check to ci.yml that verifies that this will work please? I want to try and avoid this situation in the future. It can use the |
matt2e
approved these changes
Sep 1, 2024
wesbillman
force-pushed
the
fix-extension-build
branch
from
73a90d7
to
6b656b9
Compare
wesbillman
force-pushed
the
fix-extension-build
branch
from
6b656b9
to
cb7f5ec
Compare
wesbillman
commented
Sep 2, 2024
Comment on lines
+157
to
+158
| - name: VSCode extension pnpm build and package | ||
| run: just package-extension |
There was a problem hiding this comment.
@alecthomas this should catch the error in CI now. It was just building before and not actually packaging. I'm going to avoid testing the publish in CI for now as that would be way more complex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2536