-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial Intelij plugin #2564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!!! Nice work @bradleydwyer 🥳
6b3733d
to
2d14a80
Compare
This is awesome! Though why do we want Hermit support in this plugin when there's already a Hermit plugin? Does it not interact well or something? |
- name: Install Java | ||
run: java -version | ||
- name: Build Intellij Plugin | ||
run: just build-intellij-plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How long does this take? Copy pasta the if
statement from other jobs if this is going to take more than a minute or two, so we can keep the main PR loop fast.
The Hermit plugin adds Hermit support to a couple of different IDE actions, but if you just run a process directly it won't pick up the correct Hermit environment. By running the command like through the ToolCustomizer (which the Hermit plugin provides an instance of) it picks up the hermit environment so things work as expected. It would also work with any other plugin that is doing similar things. |
2d14a80
to
631a157
Compare
Something I still need to figure out is that if you have multiple projects open only the first one will succeed, as |
0fa915d
to
4aba6c7
Compare
Looks like LSP support is paid only: https://plugins.jetbrains.com/docs/intellij/language-server-protocol.html#supported-ides Longer term LSP might not be the way to go for intellij support |
4aba6c7
to
bd60216
Compare
If you need a free LSP support for IntelliJ please try https://github.com/redhat-developer/lsp4ij
You can read an article about LSP4IJ at https://idetools.dev/blog/lsp4ij-announcement/ More and more plygins are using LSP4IJ plese see https://github.com/redhat-developer/lsp4ij?tab=readme-ov-file#requirements Hope you could be interested with LSP4IJ and don't hesitate to answer me if you have any questions. |
bd60216
to
28d79bd
Compare
@angelozerr thanks for the tip, I will check it out |
28d79bd
to
68bb475
Compare
Thanks @angelozerr, appreciate the heads up! |
…a plugin. - Basic completion of go directives - start/stop/restart of the LSP - lsp terminal output (auto scroll/clear buffer/soft wrap) - settings panel for LSP server command configuration and project working directory
This piggy backs on the Hermit plugin to get the correct FTL version.
68bb475
to
0d7726d
Compare
Thanks to @bradleydwyer
I have tested it out and added Hermit support so we run FTL with the right env.
It's not perfect but I think we should just get this in an iterate.
#2549