chore: migrate deploy_test to integration tests in buildengine #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests the same things as the old test, but through slightly higher abstraction layer (cli instead of calling build engine functions directly)
Open
jvmakine
commented
Aug 26, 2024
|
|
||
| func TestDeploy(t *testing.T) { | ||
| in.Run(t, | ||
| in.WithTestDataDir("testdata"), |
There was a problem hiding this comment.
We can remove this once all tests are integrated, and we can move the modules under corresponding language dirs.
jvmakine
requested review from
a team and
deniseli
and removed request for
a team
alecthomas
approved these changes
Aug 26, 2024
This was referenced Aug 27, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests the same things as the old test, but through slightly higher abstraction layer (cli instead of calling build engine functions directly)
The same functions as in the original test should get called via the cli in the integration test.
See #1585