fix: bug with subkeys, verify test fields on startup #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gak
added
the
run-all
Open
gak
requested review from
a team and
stuartwdouglas
and removed request for
a team
gak
force-pushed
the
gak/encryption-safety
branch
from
111673e
to
f9ff882
Compare
stuartwdouglas
approved these changes
Aug 20, 2024
alecthomas
approved these changes
Aug 20, 2024
backend/controller/sql/schema/20240820011612_encryption_verification.sql
Outdated
Show resolved
Hide resolved
|
Smoke test from an older version 👌 |
alecthomas
approved these changes
Aug 21, 2024
Comment on lines
+211
to
+213
| k.cachedDerivedMu.RLock() | ||
| primitive, ok := k.cachedDerived[subKey] | ||
| k.cachedDerivedMu.RUnlock() |
There was a problem hiding this comment.
I'd just use a Mutex and do:
k.cachedDerivedMu.Lock()
defer k.cachedDerivedMu.Unlock()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2348
Fixes #2466