fix: handle custom local names for widened types #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt2e
added
the
run-all
Open
matt2e
force-pushed
the
matt2e/widened-with-import
branch
from
87b9a1f
to
e879b00
Compare
matt2e
force-pushed
the
matt2e/widened-with-import
branch
from
e1fabcf
to
f6ef4c7
Compare
stuartwdouglas
approved these changes
Aug 19, 2024
safeer
pushed a commit
that referenced
this pull request
Aug 19, 2024
fixes #2397 `pass.Pkg.Imports()` did not always* include the local name alias from the import statement, so instead we need to do our checks via `PkgName` which does include it. *it includes it in the example in our tests, but didn't in the case that our partner project was hitting... I've added another test case that previously failed like theirs did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2397
pass.Pkg.Imports()did not always* include the local name alias from the import statement, so instead we need to do our checks viaPkgNamewhich does include it.*it includes it in the example in our tests, but didn't in the case that our partner project was hitting...
I've added another test case that previously failed like theirs did.