generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: typesafe encrypted DB columns #2400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alecthomas
force-pushed
the
aat/typesafe-encrypted-columns
branch
from
August 16, 2024 07:29
f518430
to
c015846
Compare
alecthomas
added
the
run-all
A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue
label
Aug 16, 2024
alecthomas
force-pushed
the
aat/typesafe-encrypted-columns
branch
from
August 16, 2024 07:32
c015846
to
9566356
Compare
alecthomas
force-pushed
the
aat/typesafe-encrypted-columns
branch
from
August 16, 2024 07:34
9566356
to
c13ca0a
Compare
@gak ping |
alecthomas
force-pushed
the
aat/typesafe-encrypted-columns
branch
from
August 19, 2024 08:08
c13ca0a
to
156e748
Compare
gak
reviewed
Aug 19, 2024
Request []byte | ||
Response []byte | ||
Request encryption.EncryptedAsyncColumn | ||
Response encryption.OptionalEncryptedAsyncColumn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
gak
reviewed
Aug 19, 2024
// EncryptedColumn is a type that represents an encrypted column. | ||
// | ||
// It can be used by sqlc to map to/from a bytea column in the database. | ||
type EncryptedColumn[SK SubKey] []byte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
gak
approved these changes
Aug 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 19, 2024
alecthomas
force-pushed
the
aat/typesafe-encrypted-columns
branch
from
August 19, 2024 19:31
156e748
to
4571f26
Compare
alecthomas
force-pushed
the
aat/typesafe-encrypted-columns
branch
from
August 19, 2024 19:32
4571f26
to
a7276dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
run-all
A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.