Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: typesafe encrypted DB columns #2400

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

alecthomas
Copy link
Collaborator

No description provided.

@alecthomas alecthomas requested review from gak and a team August 16, 2024 06:58
@ftl-robot ftl-robot mentioned this pull request Aug 16, 2024
@alecthomas alecthomas force-pushed the aat/typesafe-encrypted-columns branch from f518430 to c015846 Compare August 16, 2024 07:29
@alecthomas alecthomas added the run-all A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue label Aug 16, 2024
@alecthomas alecthomas force-pushed the aat/typesafe-encrypted-columns branch from c015846 to 9566356 Compare August 16, 2024 07:32
@alecthomas alecthomas force-pushed the aat/typesafe-encrypted-columns branch from 9566356 to c13ca0a Compare August 16, 2024 07:34
@alecthomas
Copy link
Collaborator Author

@gak ping

Request []byte
Response []byte
Request encryption.EncryptedAsyncColumn
Response encryption.OptionalEncryptedAsyncColumn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

// EncryptedColumn is a type that represents an encrypted column.
//
// It can be used by sqlc to map to/from a bytea column in the database.
type EncryptedColumn[SK SubKey] []byte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecthomas alecthomas added this pull request to the merge queue Aug 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2024
@alecthomas alecthomas force-pushed the aat/typesafe-encrypted-columns branch from 156e748 to 4571f26 Compare August 19, 2024 19:31
@alecthomas alecthomas force-pushed the aat/typesafe-encrypted-columns branch from 4571f26 to a7276dc Compare August 19, 2024 19:32
@alecthomas alecthomas added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit f75a5f0 Aug 19, 2024
74 checks passed
@alecthomas alecthomas deleted the aat/typesafe-encrypted-columns branch August 19, 2024 19:44
gak added a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-all A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants