feat: allow catch verbs to receive request types as any
#2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt2e
requested review from
a team and
wesbillman
and removed request for
a team
Open
matt2e
added
the
run-all
matt2e
force-pushed
the
matt2e/catch-any
branch
from
d503167
to
d0cb895
Compare
safeer
pushed a commit
that referenced
this pull request
Aug 19, 2024
closes #2213 `builtin.CatchRequest` now has the following features: - the associated request type can be `any` to allow for catching multiple verbs with different request types - The request will be unmarshalled to primitives (like string, int, map, array etc) rather than ftl structs - Includes the verb that failed as a `builtin.Ref`, which is a data type with `module` and `name` strings - Includes the request type as a string, eg: `example.Input`, `String`, etc - Originally I had this as a `builtin.Ref` but that doesnt work for non-ref types There is certainly room for improvement in terms of how we want to expose these schema definitions, but this PR doesn't try go too far down that road.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2213
builtin.CatchRequestnow has the following features:anyto allow for catching multiple verbs with different request typesbuiltin.Ref, which is a data type withmoduleandnamestringsexample.Input,String, etcbuiltin.Refbut that doesnt work for non-ref typesThere is certainly room for improvement in terms of how we want to expose these schema definitions, but this PR doesn't try go too far down that road.