fix: turns out ON CONFLICT DO NOTHING doesn't work with RETURNING #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
requested review from
a team and
stuartwdouglas
and removed request for
a team
Open
alecthomas
commented
Aug 15, 2024
| @@ -45,7 +45,7 @@ type serveCmd struct { | |||
| Stop bool `help:"Stop the running FTL instance. Can be used with --background to restart the server" default:"false"` | |||
| StartupTimeout time.Duration `help:"Timeout for the server to start up." default:"1m"` | |||
| ObservabilityConfig observability.Config `embed:"" prefix:"o11y-"` | |||
| DatabaseImage string `help:"The container image to start for the database" default:"postgres:15.4" env:"FTL_DATABASE_IMAGE" hidden:""` | |||
| DatabaseImage string `help:"The container image to start for the database" default:"postgres:15.8" env:"FTL_DATABASE_IMAGE" hidden:""` | |||
There was a problem hiding this comment.
This now matches the version in the Docker compose file.
stuartwdouglas
approved these changes
Aug 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Maybe we should run the build all task as part of a normal PR, as it now picks up SCM changes to that happen when building. |
wesbillman
approved these changes
Aug 15, 2024
|
I'm going to add a test. |
alecthomas
force-pushed
the
aat/fix-upload-conflict-2
branch
from
3f3e014
to
1ed0ee3
Compare
It's pretty slow unfortunately, which is why I excluded it :( |
alecthomas
force-pushed
the
aat/fix-upload-conflict-2
branch
from
1ed0ee3
to
d5e087f
Compare
The workaround is to do a dummy update and return the updated id. Also added a test.
alecthomas
force-pushed
the
aat/fix-upload-conflict-2
branch
from
d5e087f
to
7d9a2e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround is to do a dummy update and return the updated id.