feat: adopt Grafana for metrics visualization (#2364) #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanj-square
requested review from
a team and
worstell
and removed request for
a team
Open
alecthomas
approved these changes
Aug 15, 2024
.env
Outdated
| @@ -0,0 +1,2 @@ | |||
| OTEL_GRPC_PORT=4317 | |||
| OTEL_HTTP_PORT=4318 | |||
There was a problem hiding this comment.
Use Hermit for managing these envars instead:
hermit env OTEL_GRPC_PORT 4317
hermit env OTEL_HTTP_PORT 4318
There was a problem hiding this comment.
thanks updated; didn't know of this option
| grafana: | ||
| image: grafana/otel-lgtm | ||
| platform: linux/amd64 | ||
| restart: unless-stopped |
There was a problem hiding this comment.
Add the infra profile here so it doesn't start by default. You'll also need to add that to the docker compose lines that bring it up/down.
Justfile
Outdated
| -p 55679:55679 \ | ||
| otel/opentelemetry-collector:0.104.0 2>&1 | sed 's/\([A-Z].* #\)/\ | ||
| \1/g' | ||
|
|
||
| # Stop the docker container running otel. | ||
| otelContainerID := `docker ps -f ancestor=otel/opentelemetry-collector:0.104.0 | tail -1 | cut -d " " -f1` | ||
| otel-container-id := `docker ps -f ancestor=otel/opentelemetry-collector:0.104.0 | tail -1 | cut -d " " -f1` | ||
| grafana-container-id := `docker ps -f ancestor=grafana/otel-lgtm | tail -1 | cut -d " " -f1` |
There was a problem hiding this comment.
Unless this is doing something I'm not aware of, couldn't we just use docker compose down instead of this?
|
@jonathanj-square I pulled it out of the queue because there are a couple of changes that would be nice to make |
jonathanj-square
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
safeer
pushed a commit
that referenced
this pull request
Aug 19, 2024
fixes: #2364 Introduces a Grafana / OTEL container for capturing, ephemerally storing, and visualizing OTEL metrics emitted by FTL. The collection frequency is also increased to once per second (from a default once per minute) <img width="1246" alt="Screenshot 2024-08-14 at 7 58 39 PM" src="https://github.com/user-attachments/assets/bd21cd33-dc93-4a79-9b2a-ad124f2db296">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2364
Introduces a Grafana / OTEL container for capturing, ephemerally storing, and visualizing OTEL metrics emitted by FTL. The collection frequency is also increased to once per second (from a default once per minute)