Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: possible race on artefact upload #2368

Closed
wants to merge 2 commits into from
Closed

fix: possible race on artefact upload #2368

wants to merge 2 commits into from

Conversation

stuartwdouglas
Copy link
Collaborator

fixes: #2367

@stuartwdouglas stuartwdouglas requested review from a team and wesbillman and removed request for a team August 14, 2024 23:49
alecthomas
alecthomas reviewed Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a slightly better but somewhat more involved fix here, let me send through a PR.

@stuartwdouglas
Copy link
Collaborator Author

You mean to maintain an updated list of new artifacts in case there are multiple failures? I thought about I was not sure if it was worth extra complexity.

@ftl-robot ftl-robot mentioned this pull request Aug 14, 2024
Open
@stuartwdouglas stuartwdouglas deleted the stuartwdouglas/2367 branch August 15, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas left review comments

@wesbillman wesbillman Awaiting requested review from wesbillman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't deploy two Java apps at once
2 participants
@stuartwdouglas @alecthomas