chore: update versions in files #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team and
wesbillman
and removed request for
a team
stuartwdouglas
force-pushed
the
stuartwdouglas/build-all
branch
from
007ae72
to
302562e
Compare
Open
stuartwdouglas
force-pushed
the
stuartwdouglas/build-all
branch
from
302562e
to
d450c3f
Compare
wesbillman
approved these changes
Aug 12, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
171
to
179
| - name: Check No SCM Changes | ||
| run: | | ||
| if [[ -n $(git status -s) ]] | ||
| then | ||
| echo "Running the build resulted in changes to git controlled files:" | ||
| git --no-pager diff | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Nice! This is great. I also notice that lsp/hoveritems.go changes pretty often when I just clean and just build-all locally, so hopefully this will catch that case as well 👍
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
Running just build-all will cause these changes, commiting them so that building does not modify source controlled files. Also add a check for this so we won't get into this state in future.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
stuartwdouglas
force-pushed
the
stuartwdouglas/build-all
branch
from
d450c3f
to
cbcfd39
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Running just build-all will cause these changes, commiting them so that building does not modify source controlled files.
stuartwdouglas
force-pushed
the
stuartwdouglas/build-all
branch
from
cbcfd39
to
149b0dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running just build-all will cause these changes, commiting them so that building does not modify source controlled files.
Also add a check for this so we won't get into this state in future.