-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(topic): require lowerCamel topic names instead of lower_snake #2329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to hold off on merging this? It's any easy-enough change on the customer repo, but if they need to do some sort of emergency deploy, it'd be annoying if they suddenly needed to rename all the topics at the same time.
Maybe we can just plan this with the customer repo. It might be a good time to get some of this in and we can manually update the db(s) as needed to get them running again. I'm happy to help with this and pair with us/them on getting it deployed. |
@mistermoe has said it's okay to wipe the databases (except the secrets) table @gak also has a breaking change he wants to get in, so let's merge these changes but not deploy until we have both in |
@alecthomas I was going to help deploy the topic names PR today, but sounds like we'll need to wait for @gak's change as well, so we can do a deploy this evening or tomorrow instead 👍 |
Breaking change, fixes #2328
Original topic name PR is #1958