Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ftl new fails #2326

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix: ftl new fails #2326

merged 1 commit into from
Aug 12, 2024

Conversation

stuartwdouglas
Copy link
Collaborator

The directory was being prefixed to the path twice.

fixes #2297

The directory was being prefixed to the path twice.

fixes #2297
@stuartwdouglas stuartwdouglas requested review from a team and worstell and removed request for a team August 12, 2024 07:11
@ftl-robot ftl-robot mentioned this pull request Aug 12, 2024
@stuartwdouglas stuartwdouglas added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 001a3d2 Aug 12, 2024
18 checks passed
@stuartwdouglas stuartwdouglas deleted the stuartwdouglas/2297 branch August 12, 2024 07:46
@@ -79,7 +79,7 @@ func (i newGoCmd) Run(ctx context.Context) error {
return err
}
}
if err := maybeGitAdd(ctx, i.Dir, filepath.Join(path, "*")); err != nil {
if err := maybeGitAdd(ctx, i.Dir, filepath.Join(i.Name, "*")); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stuartwdouglas!

@wesbillman wesbillman added the approved Marks an already closed PR as approved label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Marks an already closed PR as approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ftl new go ./foo bar fails
3 participants