feat: allow FSMs to specify the next event to send #1723
Conversation
alecthomas
force-pushed
the
aat/fsm-set-next-event
branch
2 times, most recently
from
c34d1f8
to
42f0e72
Compare
matt2e
force-pushed
the
aat/fsm-set-next-event
branch
2 times, most recently
from
e70ecb5
to
3845ebd
Compare
matt2e
force-pushed
the
aat/fsm-set-next-event
branch
from
76cfcb2
to
7b73b49
Compare
matt2e
requested review from
a team and
jonathanj-square
and removed request for
a team
|
@alecthomas Please review if you get a chance, even though you're not a reviewer because you're the author |
| // Each transition also declares the next state(s) to transition to using State | ||
| // | ||
| //ftl:retry 2 1s | ||
| var fsm = ftl.FSM("fsm", |
There was a problem hiding this comment.
Would it be better to introduce ftl.FSMNext() in this PR so we don't establish this pattern at all?
There was a problem hiding this comment.
@alecthomas I've added that now. Do you know why the grpc for a call included metadata key value pairs? I can't see it used anywhere, but this seemed like a reasonable use case for it so I piggy backed on it. What do you think?
Isolated commit here: move from fsm.Next() to FSMNext()
| } | ||
|
|
||
| //ftl:typealias | ||
| type EventB Event |
There was a problem hiding this comment.
What's the purpose of the type aliases? Unless there's a reason it would probably be simpler and less confusing to use type EventB struct {}
| validateAsyncCall("created", "Rosebud"), | ||
| validateAsyncCall("paid", "Rosebud"), | ||
|
|
There was a problem hiding this comment.
This tests is for encryption, can we move these changes to a new test?
There was a problem hiding this comment.
The changes to this test are to make sure we are encrypting the payload in the fsm next event table
matt2e
force-pushed
the
aat/fsm-set-next-event
branch
2 times, most recently
from
ed4048f
to
024bd8f
Compare
matt2e
added
the
run-all
matt2e
force-pushed
the
aat/fsm-set-next-event
branch
from
024bd8f
to
7915692
Compare
# Conflicts: # backend/controller/dal/fsm.go # backend/controller/dal/fsm_integration_test.go # internal/encryption/integration_test.go
matt2e
force-pushed
the
aat/fsm-set-next-event
branch
from
88c2d1b
to
86a7321
Compare
matt2e
force-pushed
the
aat/fsm-set-next-event
branch
from
bc89136
to
5f3a3a0
Compare
closes #1664
closes #2334
This is particularly useful when an FSM state itself knows which state it should be in next, for example transitioning a payment to "voided" if an error occurs communicating with an external vendor.
fsm.Next(ctx, event)to the go runtimeIn another PR we will move away from using
ftl.Next()to avoid the reference cycle issue.