feat: refactor schema error handling from Go #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
changed the title
Open
worstell
force-pushed
the
worstell/20240418-fix-errors
branch
from
265c9ba
to
9279b61
Compare
|
|
worstell
force-pushed
the
worstell/20240418-fix-errors
branch
from
9279b61
to
58502bf
Compare
fixed! |
wesbillman
approved these changes
Apr 19, 2024
Comment on lines
+38
to
+40
| if err := os.RemoveAll(filepath.Join(module.AbsDeployDir(), module.Errors)); err != nil { | ||
| return fmt.Errorf("failed to clear errors: %w", err) | ||
| } |
backend/schema/errors.go
Outdated
Comment on lines
98
to
100
| if len(merr) == 0 { | ||
| return | ||
| } |
There was a problem hiding this comment.
Mostly just for my info, but is this check needed? Would just sort.Slice on an empty slice do the same thing?
There was a problem hiding this comment.
nope you're totally right - removed!
- no longer pass Go compiler errors through the LSP
- instead of attempting to parse out schema/build errors from an aggregate error, we pass back schema errors and non-schema errors ("real" exceptions) explicitly and separately
fixes #1299
|
It's beautiful!! :) |
worstell
force-pushed
the
worstell/20240418-fix-errors
branch
from
58502bf
to
0a46d7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1299