chore: globally replace ftl in go.mod #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever we do `ftl init go ...` in a test, by default this will be configured to pull the FTL source from GitHub. This PR changes that to always use the local FTL, which is much more correct. This has confused me many times.
alecthomas
requested review from
dhanji,
wesbillman,
worstell and
matt2e
as code owners
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we do
ftl init go ...in a test, by default the new module will be configured to pull the FTL source from GitHub. This is both slow and incorrect. This PR changes that to always use the local FTL.This has confused me many times.
@TBD54566975/ftl-team heads up that once this lands, any time you run
ftl init goyou will get a fully-qualified replacement path that won't work in CI. This is fine for tests generated on the fly, but not so good for code that is checked in - we'll need to ensure that we manually fix the path.eg. it will look like this:
Whereas in order to work across machines it will need to be relative, eg.