fix: improve error positioning on unsupported basic types #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wesbillman
commented
Apr 10, 2024
wesbillman
commented
wesbillman
requested review from
alecthomas,
dhanji,
worstell and
matt2e
as code owners
Open
worstell
approved these changes
Apr 10, 2024
alecthomas
reviewed
Apr 10, 2024
| @@ -198,10 +197,27 @@ func getLineOrWordLength(filePath string, lineNum, column int, wholeLine bool) ( | |||
| return len(lineText), nil | |||
There was a problem hiding this comment.
This function really needs to be replaced. Do we have a ticket for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.