feat: use export annotation #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
worstell
force-pushed
the
worstell/20240320-use-export-directive
branch
from
f77ce4e
to
08cf1cc
Compare
Open
worstell
added a commit
that referenced
this pull request
Mar 21, 2024
sort of testing a hypothesis, but i suspect the build cache needs to be rebuilt against [this](#1117) branch in order for [this](https://github.com/TBD54566975/ftl/actions/runs/8370343139/job/22939654513) to pass if this fixes the problem, we should probably figure out a better approach to ensuring the kotlin-runtime JAR is up-to-date with the local Kotlin when running Go tests, now that Go tests also exercise Kotlin code
worstell
force-pushed
the
worstell/20240320-use-export-directive
branch
3 times, most recently
from
c3451a8
to
dda78bf
Compare
worstell
commented
Mar 21, 2024
| @@ -30,6 +30,9 @@ jobs: | |||
| uses: cashapp/activate-hermit@v1 | |||
| - name: Build Cache | |||
| uses: ./.github/actions/build-cache | |||
| # TODO: remove, testing this | |||
| - name: Build Kotlin | |||
| run: just build-kt-runtime | |||
There was a problem hiding this comment.
there's an issue with caching happening; Test Go fails without this step because buildengine exercises Kotlin code in the Go tests now. the cached build uses a kotlin-runtime version that's missing the necessary local changes from this PR
There was a problem hiding this comment.
As we discussed, this should stay here.
There was a problem hiding this comment.
I'm actually surprised the ftl development build didn't do this automatically.
alecthomas
approved these changes
Mar 22, 2024
- Go: Replaces `ftl:verb` and `ftl:enum` with `ftl:export` - Kotlin: Replaces `@Verb` with `@Export` - Updates runtime schema extractors to pull standalone data decls annotated with `export` Design here: https://hackmd.io/i5COidF3SEynCab8VcJwng fixes #1114
worstell
force-pushed
the
worstell/20240320-use-export-directive
branch
from
dda78bf
to
65f7564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ftl:verbandftl:enumwithftl:export, removesftl:module <name>annotation@Verbwith@ExportexportDesign here: https://hackmd.io/i5COidF3SEynCab8VcJwng
fixes #1114