feat: extract configs/secrets in kotlin #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
Open
worstell
force-pushed
the
worstell/20240319-extract-secrets-configs-in-kotlin
branch
2 times, most recently
from
d612b53
to
946088f
Compare
worstell
force-pushed
the
worstell/20240319-extract-secrets-configs-in-kotlin
branch
from
a73f8eb
to
e1a708b
Compare
alecthomas
approved these changes
Mar 20, 2024
| return file.declarations | ||
| .filter { | ||
| (it as? KtProperty) | ||
| ?.getDeclarationDescriptorIncludingConstructors(bindingContext)?.referencedProperty?.returnType |
There was a problem hiding this comment.
getDeclarationDescriptorIncludingConstructors
Nice succinct method!
worstell
deleted the
worstell/20240319-extract-secrets-configs-in-kotlin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1092