chore: fix for local dev rebuilding ftl-runtime.jar on every run #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was occurring because frontend/local.go was calling `npm install` explicitly on every run, resulting in changes to the frontend that invalidated some of the dependencies of the JAR file. The fix is to use `bit` to build the frontend as well, resulting in its dependency cache being correct.
Open
wesbillman
reviewed
Mar 8, 2024
| @@ -114,7 +114,7 @@ kotlin-runtime/external-module-template.zip: kotlin-runtime/external-module-temp | |||
| # TODO: Figure out how to make Maven build completely offline. Bizarrely "-o" does not do this. | |||
| build: | |||
| mvn -B -N install | |||
| mvn -B -pl :ftl-runtime install | |||
| mvn -Dmaven.test.skip=true -B -pl :ftl-runtime install | |||
There was a problem hiding this comment.
It's so strange to me that the default is to run tests when building. mvn is weird.
There was a problem hiding this comment.
Definitely agree, super weird...and irritating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was occurring because frontend/local.go was calling
npm installexplicitly on every run, resulting in changes to the frontend that invalidated some of the dependencies of the JAR file.The fix is to use
bitto build the frontend as well, resulting in its dependency cache being correct.