feat: partial implemention of the secrets/config design #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
requested review from
dhanji,
wesbillman and
worstell
as code owners
Design is [here](https://hackmd.io/@ftl/S1e6YVEuq6). Specifically, this doesn't implement any of the backend changes, only the layered reference storage approach. References are currently only stored in an `ftl-project.toml` file stored at the root of the repository. It supports the following configuration providers: - Inlined. - Environment variables. - 1Password [secret references](https://developer.1password.com/docs/cli/secret-references/) - The system keychain. Fixes #1001
alecthomas
force-pushed
the
aat/configuration-api
branch
from
048aab8
to
9241b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design is here.
Specifically, this doesn't implement any of the backend changes, only the layered reference storage approach. References are currently only stored in an
ftl-project.tomlfile stored at the root of the repository.It supports the following configuration providers:
Note also that this is not hooked up to the Go runtime yet. Will do that in a followup. Kotlin will have to wait until the full backend implementation is available.
Fixes #1001