Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode extension release fails #2536

Closed
alecthomas opened this issue Aug 29, 2024 · 1 comment · Fixed by #2565
Closed

VSCode extension release fails #2536

alecthomas opened this issue Aug 29, 2024 · 1 comment · Fixed by #2565
Assignees
@wesbillman
Labels
bug Something isn't working codebase-health Codebase health dx P0 Work on this now

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Aug 29, 2024 •
edited
Loading

Example here. Looks like it's still using npm and should be switched to pnpm too?

If possible let's also add something to the PR pipeline that verifies that this step will succeed on release.
@github-actions github-actions bot added the triage Issue needs triaging label Aug 29, 2024
@alecthomas alecthomas added dx bug Something isn't working codebase-health Codebase health and removed triage Issue needs triaging labels Aug 29, 2024
@alecthomas alecthomas added the P0 Work on this now label Aug 29, 2024
This was referenced Aug 29, 2024
Open
Open
@wesbillman
Copy link
Member

I think this might be a cache issue. I'm going to watch this next release to see how it goes

@wesbillman wesbillman mentioned this issue Aug 30, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 2, 2024
@wesbillman
fix: publishing vscode extension (#2565)
b839df5 
Fixes #2536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesbillman wesbillman

Labels
bug Something isn't working codebase-health Codebase health dx P0 Work on this now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: publishing vscode extension TBD54566975/ftl
2 participants
@alecthomas @wesbillman