Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate naming of topics/subscriptions to lowerCamelCase #2328

Closed
alecthomas opened this issue Aug 12, 2024 · 0 comments · Fixed by #2329
Closed

Migrate naming of topics/subscriptions to lowerCamelCase #2328

alecthomas opened this issue Aug 12, 2024 · 0 comments · Fixed by #2329
Assignees
@safeer

Comments

@alecthomas
Copy link
Collaborator

They are currently lower_snake_case, which is inconsistent with all other identifiers in FTL. This will entail something like:

  1. Change FTL to require lowerCamelCase.
  2. Change source code from eg. var OutgoingMessagesTopic = ftl.Topic[OutgoingMessageEvent]("outgoing_messages_topic") to var OutgoingMessagesTopic = ftl.Topic[OutgoingMessageEvent]("outgoingMessagesTopic")
  3. Rename topics in database.
@alecthomas alecthomas added the triage Issue needs triaging label Aug 12, 2024
@ftl-robot ftl-robot mentioned this issue Aug 12, 2024
Open
@safeer safeer mentioned this issue Aug 12, 2024
Merged
@worstell worstell removed the triage Issue needs triaging label Aug 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 13, 2024
@safeer
fix(topic): require lowerCamel topic names instead of lower_snake (#2329
a5425b1 
)

Breaking change, fixes #2328

Original topic name PR is #1958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@safeer safeer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(topic): require lowerCamel topic names instead of lower_snake TBD54566975/ftl
3 participants
@alecthomas @safeer @worstell