Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It seems that errors.pb might persist across builds under some circumstances #1299

Closed
alecthomas opened this issue Apr 18, 2024 · 0 comments · Fixed by #1308
Closed

It seems that errors.pb might persist across builds under some circumstances #1299

alecthomas opened this issue Apr 18, 2024 · 0 comments · Fixed by #1308
Assignees
@worstell
Labels
bug Something isn't working

Comments

@alecthomas
Copy link
Collaborator

I checked out online-boutique and was updating it to latest ftl. The first build failed because it was still using ftl:verb rather than ftl:export. I fixed that, but then the next build still resulted in the same errors:

trace: /xyz.block.ftl.v1.ControllerService/PullSchema (streaming client)
ftl: error: /Users/alec/dev/ftl-examples/online-boutique/backend/services/cart/cart.go:30:3-3: unexpected token "verb" (expecte
d Directive)
            /Users/alec/dev/ftl-examples/online-boutique/backend/services/cart/cart.go:43:3-3: unexpected token "verb" (expecte
d Directive)
            /Users/alec/dev/ftl-examples/online-boutique/backend/services/cart/cart.go:57:3-3: unexpected token "verb" (expecte
d Directive)

It seems like errors.pb is not being cleared between builds, resulting in previous errors persisting.
@alecthomas alecthomas added the bug Something isn't working label Apr 18, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Apr 18, 2024
@alecthomas alecthomas mentioned this issue Apr 18, 2024
Open
worstell added a commit that referenced this issue Apr 18, 2024
@worstell
feat: refactor schema error passing from Go
b58caa1 
- no longer pass Go compiler errors through the LSP
- instead of attempting to parse out schema/build errors from an aggregate error, we pass back schema errors and non-schema errors ("real" exceptions) explicitly and separately

fixes #1299
worstell added a commit that referenced this issue Apr 18, 2024
@worstell
feat: refactor schema error passing from Go
0d24bac 
- no longer pass Go compiler errors through the LSP
- instead of attempting to parse out schema/build errors from an aggregate error, we pass back schema errors and non-schema errors ("real" exceptions) explicitly and separately

fixes #1299
worstell added a commit that referenced this issue Apr 19, 2024
@worstell
feat: refactor schema error passing from Go
265c9ba 
- no longer pass Go compiler errors through the LSP
- instead of attempting to parse out schema/build errors from an aggregate error, we pass back schema errors and non-schema errors ("real" exceptions) explicitly and separately

fixes #1299
@worstell worstell mentioned this issue Apr 19, 2024
Merged
worstell added a commit that referenced this issue Apr 19, 2024
@worstell
feat: refactor schema error passing from Go
9279b61 
- no longer pass Go compiler errors through the LSP
- instead of attempting to parse out schema/build errors from an aggregate error, we pass back schema errors and non-schema errors ("real" exceptions) explicitly and separately

fixes #1299
@worstell worstell self-assigned this Apr 19, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Apr 19, 2024
worstell added a commit that referenced this issue Apr 19, 2024
@worstell
feat: refactor schema error passing from Go
58502bf 
- no longer pass Go compiler errors through the LSP
- instead of attempting to parse out schema/build errors from an aggregate error, we pass back schema errors and non-schema errors ("real" exceptions) explicitly and separately

fixes #1299
worstell added a commit that referenced this issue Apr 19, 2024
@worstell
feat: refactor schema error passing from Go
0a46d7a 
- no longer pass Go compiler errors through the LSP
- instead of attempting to parse out schema/build errors from an aggregate error, we pass back schema errors and non-schema errors ("real" exceptions) explicitly and separately

fixes #1299
worstell added a commit that referenced this issue Apr 19, 2024
@worstell
feat: refactor schema error handling from Go (#1308)
8544aa0 
- no longer pass Go compiler errors through the LSP
- instead of attempting to parse out schema/build errors from an
aggregate error, we pass back schema errors and non-schema errors
("real" exceptions) explicitly and separately
- add errors build file to the ModuleConfig

fixes #1299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@worstell worstell

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: refactor schema error handling from Go TBD54566975/ftl
2 participants
@alecthomas @worstell