Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File updates in quick succession leads to unnecessary builds #1210

Closed
matt2e opened this issue Apr 9, 2024 · 0 comments · Fixed by #1279
Closed

File updates in quick succession leads to unnecessary builds #1210

matt2e opened this issue Apr 9, 2024 · 0 comments · Fixed by #1279
Assignees
Labels
good first issue Good for newcomers

Comments

@matt2e
Copy link
Collaborator

matt2e commented Apr 9, 2024

Steps to repro:

  • run ftl dev with some modules
  • start editing the code for a module
  • make a small change, save the file, and repeat a few times in quick succession

FTL will queue up all these builds for the same module. After the last save, ftl will have a few of these in the queue. FTL will then build this same module a few times with the same result each time, which is unnecessary.
Possibly, we could look at the existing build to see if it started after the current message, as that would indicate the file change had already been included in the current build.

@matt2e matt2e added the good first issue Good for newcomers label Apr 9, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Apr 9, 2024
@alecthomas alecthomas mentioned this issue Apr 9, 2024
@wesbillman wesbillman added next Work that will be be picked up next and removed triage Issue needs triaging labels Apr 10, 2024
@wesbillman wesbillman self-assigned this Apr 15, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Apr 15, 2024
wesbillman added a commit that referenced this issue Apr 16, 2024
Fixes #1210 

This required a bit of a refactor to use pointers for `Module` and
`ExternalLibrary` here. Hopefully, that's ok.

Example of rapid changes getting skipped. Note that I logged skips in
`Warnf` just to highlight for this screenshot. Real skip messages are
logged at `Debugf`

![Screenshot 2024-04-16 at 2 03
09 PM](https://github.com/TBD54566975/ftl/assets/51647/079878c6-3fa6-4f4c-9705-7a422e639db6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants