Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a subset of the config/secret design doc #1001

Closed
alecthomas opened this issue Feb 28, 2024 · 0 comments · Fixed by #1003
Closed

Implement a subset of the config/secret design doc #1001

alecthomas opened this issue Feb 28, 2024 · 0 comments · Fixed by #1003
Assignees
@alecthomas

Comments

@alecthomas
Copy link
Collaborator

The current way secrets are managed through Hermit envars is really poor. Let's implement the first half of the design such that the ftl CLI can be used to manage local secrets from the project config, and keychain. This will solve a few initial problems.
@alecthomas alecthomas self-assigned this Feb 28, 2024
@github-actions github-actions bot added triage Issue needs triaging and removed triage Issue needs triaging labels Feb 28, 2024
@alecthomas alecthomas mentioned this issue Feb 28, 2024
Open
alecthomas added a commit that referenced this issue Feb 29, 2024
@alecthomas
feat: partial implemention of the secrets/config design
048aab8 
Design is [here](https://hackmd.io/@ftl/S1e6YVEuq6).

Specifically, this doesn't implement any of the backend changes, only
the layered reference storage approach. References are currently only
stored in an `ftl-project.toml` file stored at the root of the
repository.

It supports the following configuration providers:

- Inlined.
- Environment variables.
- 1Password [secret references](https://developer.1password.com/docs/cli/secret-references/)
- The system keychain.

Fixes #1001
@alecthomas alecthomas mentioned this issue Feb 29, 2024
Merged
alecthomas added a commit that referenced this issue Feb 29, 2024
@alecthomas
feat: partial implemention of the secrets/config design
9241b79 
Design is [here](https://hackmd.io/@ftl/S1e6YVEuq6).

Specifically, this doesn't implement any of the backend changes, only
the layered reference storage approach. References are currently only
stored in an `ftl-project.toml` file stored at the root of the
repository.

It supports the following configuration providers:

- Inlined.
- Environment variables.
- 1Password [secret references](https://developer.1password.com/docs/cli/secret-references/)
- The system keychain.

Fixes #1001
alecthomas added a commit that referenced this issue Feb 29, 2024
@alecthomas
feat: partial implemention of the secrets/config design (#1003)
a9c3ab3 
Design is [here](https://hackmd.io/@ftl/S1e6YVEuq6).

Specifically, this doesn't implement any of the backend changes, only
the layered reference storage approach. References are currently only
stored in an `ftl-project.toml` file stored at the root of the
repository.

It supports the following configuration providers:

- Inlined.
- Environment variables.
- 1Password [secret
references](https://developer.1password.com/docs/cli/secret-references/)
- The system keychain.

Note also that this is not hooked up to the Go runtime yet. Will do that
in a followup. Kotlin will have to wait until the full backend
implementation is available.

Fixes #1001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecthomas alecthomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: partial implemention of the secrets/config design TBD54566975/ftl
1 participant
@alecthomas