fix: do not parse associated types as refs (#2504)

fixes #2503
TBD54566975 · Aug 27, 2024 · e309020 · e309020
1 parent 992d72c
commit e309020
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/go-runtime/compile/build.go b/go-runtime/compile/build.go
@@ -400,12 +400,10 @@ var scaffoldFuncs = scaffolder.FuncMap{
 				imports[path.Join("ftl", n.Module)] = "ftl" + n.Module
 
 				for _, tp := range n.TypeParameters {
-					tpRef, err := schema.ParseRef(tp.String())
-					if err != nil {
-						panic(err)
-					}
-					if tpRef.Module != "" && tpRef.Module != m.Name {
-						imports[path.Join("ftl", tpRef.Module)] = "ftl" + tpRef.Module
+					if tpRef, ok := tp.(*schema.Ref); ok {
+						if tpRef.Module != "" && tpRef.Module != m.Name {
+							imports[path.Join("ftl", tpRef.Module)] = "ftl" + tpRef.Module
+						}
 					}
 				}
 

diff --git a/go-runtime/compile/testdata/go/two/two.go b/go-runtime/compile/testdata/go/two/two.go
@@ -2,6 +2,7 @@ package two
 
 import (
 	"context"
+	"ftl/builtin"
 
 	"github.com/TBD54566975/ftl/go-runtime/ftl"
 	lib "github.com/TBD54566975/ftl/go-runtime/schema/testdata"
@@ -114,3 +115,8 @@ func superTransitiveVerbCall(ctx context.Context, req Payload[string]) error {
 	_, err := ftl.Call(ctx, Three, req)
 	return err
 }
+
+//ftl:verb export
+func CatchArray(ctx context.Context, req builtin.CatchRequest[[]TwoEnum]) error {
+	return nil
+}