Skip to content

Commit

Permalink
chore: delete unused console FSM stuff
Browse files Browse the repository at this point in the history
  • Loading branch information
wesbillman committed Nov 5, 2024
1 parent 5acf7d7 commit d3d2f5b
Show file tree
Hide file tree
Showing 8 changed files with 62 additions and 81 deletions.
2 changes: 0 additions & 2 deletions backend/controller/console/console.go
Original file line number Diff line number Diff line change
Expand Up @@ -805,8 +805,6 @@ func eventDALToProto(event timeline.Event) *pbconsole.Event {
asyncEventType = pbconsole.AsyncExecuteEventType_ASYNC_EXECUTE_EVENT_TYPE_UNKNOWN
case timeline.AsyncExecuteEventTypeCron:
asyncEventType = pbconsole.AsyncExecuteEventType_ASYNC_EXECUTE_EVENT_TYPE_CRON
case timeline.AsyncExecuteEventTypeFSM:
asyncEventType = pbconsole.AsyncExecuteEventType_ASYNC_EXECUTE_EVENT_TYPE_FSM
case timeline.AsyncExecuteEventTypePubSub:
asyncEventType = pbconsole.AsyncExecuteEventType_ASYNC_EXECUTE_EVENT_TYPE_PUBSUB
}
Expand Down
1 change: 0 additions & 1 deletion backend/controller/timeline/events_async.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ type AsyncExecuteEventType string
const (
AsyncExecuteEventTypeUnkown AsyncExecuteEventType = "unknown"
AsyncExecuteEventTypeCron AsyncExecuteEventType = "cron"
AsyncExecuteEventTypeFSM AsyncExecuteEventType = "fsm"
AsyncExecuteEventTypePubSub AsyncExecuteEventType = "pubsub"
)

Expand Down
107 changes: 51 additions & 56 deletions backend/protos/xyz/block/ftl/v1/console/console.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions backend/protos/xyz/block/ftl/v1/console/console.proto
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ enum EventType {
enum AsyncExecuteEventType {

Check failure on line 24 in backend/protos/xyz/block/ftl/v1/console/console.proto

View workflow job for this annotation

GitHub Actions / Proto Breaking Change Check

Previously present enum value "3" on enum "AsyncExecuteEventType" was deleted.
ASYNC_EXECUTE_EVENT_TYPE_UNKNOWN = 0;
ASYNC_EXECUTE_EVENT_TYPE_CRON = 1;
ASYNC_EXECUTE_EVENT_TYPE_FSM = 2;
ASYNC_EXECUTE_EVENT_TYPE_PUBSUB = 3;
ASYNC_EXECUTE_EVENT_TYPE_PUBSUB = 2;

Check failure on line 27 in backend/protos/xyz/block/ftl/v1/console/console.proto

View workflow job for this annotation

GitHub Actions / Proto Breaking Change Check

Enum value "2" on enum "AsyncExecuteEventType" changed name from "ASYNC_EXECUTE_EVENT_TYPE_FSM" to "ASYNC_EXECUTE_EVENT_TYPE_PUBSUB".
}

enum LogLevel {
Expand Down
4 changes: 1 addition & 3 deletions frontend/console/src/features/timeline/timeline.utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,8 @@ export const asyncEventTypeString = (type: AsyncExecuteEventType) => {
switch (type) {
case AsyncExecuteEventType.CRON:
return 'cron'
case AsyncExecuteEventType.FSM:
return 'FSM'
case AsyncExecuteEventType.PUBSUB:
return 'PubSub'
return 'pubsub'
default:
return 'unknown'
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit d3d2f5b

Please sign in to comment.