fix: possible race in reset subscription (#2301)

only update cursor, leave state as-is fixes #2261
TBD54566975 · Aug 12, 2024 · bf981b0 · bf981b0
1 parent a930215
commit bf981b0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/backend/controller/sql/queries.sql b/backend/controller/sql/queries.sql
@@ -866,8 +866,7 @@ WITH event AS (
   WHERE "key" = $2::topic_event_key
 )
 UPDATE topic_subscriptions
-SET state = 'idle',
-    cursor = (SELECT id FROM event)
+SET cursor = (SELECT id FROM event)
 WHERE key = $1::subscription_key;
 
 -- name: GetTopic :one

diff --git a/backend/controller/sql/queries.sql.go b/backend/controller/sql/queries.sql.go
diff --git a/lsp/hoveritems.go b/lsp/hoveritems.go