Skip to content

Commit

Permalink
fix: do not verify obfuscated contents of 1password (#1999)
Browse files Browse the repository at this point in the history
We now obfuscate secrets which caused errors when retrieving values from
1Password because the provider was making sure the value was json
  • Loading branch information
matt2e authored Jul 8, 2024
1 parent 06b763e commit 1c296f5
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions common/configuration/1password_provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,6 @@ func (o OnePasswordProvider) Load(ctx context.Context, ref Ref, key *url.URL) ([
return nil, fmt.Errorf("password field not found in item %q", ref)
}

// Just to verify that it is JSON encoded.
var decoded interface{}
err = json.Unmarshal(secret, &decoded)
if err != nil {
return nil, fmt.Errorf("secret is not JSON encoded: %w", err)
}

return secret, nil
}

Expand Down

0 comments on commit 1c296f5

Please sign in to comment.