feat: obervability support for JVM

fixes: #3041
TBD54566975 · Oct 9, 2024 · 11fb717 · 11fb717
1 parent f4fab8c
commit 11fb717
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 6 deletions.
diff --git a/jvm-runtime/ftl-runtime/common/deployment/pom.xml b/jvm-runtime/ftl-runtime/common/deployment/pom.xml
@@ -23,6 +23,10 @@
             <groupId>io.quarkus</groupId>
             <artifactId>quarkus-rest-jackson-deployment</artifactId>
         </dependency>
+        <dependency>
+            <groupId>io.quarkus</groupId>
+            <artifactId>quarkus-opentelemetry-deployment</artifactId>
+        </dependency>
         <dependency>
             <groupId>io.quarkus</groupId>
             <artifactId>quarkus-agroal-spi</artifactId>

diff --git a/...ck/ftl/deployment/BannerConfigSource.java → ...ck/ftl/deployment/StaticConfigSource.java b/...ck/ftl/deployment/BannerConfigSource.java → ...ck/ftl/deployment/StaticConfigSource.java
@@ -4,9 +4,10 @@
 
 import org.eclipse.microprofile.config.spi.ConfigSource;
 
-public class BannerConfigSource implements ConfigSource {
+public class StaticConfigSource implements ConfigSource {
 
     public static final String QUARKUS_BANNER_ENABLED = "quarkus.banner.enabled";
+    final static String OTEL_METRICS_ENABLED = "quarkus.otel.metrics.enabled";
 
     @Override
     public Set<String> getPropertyNames() {
@@ -15,14 +16,19 @@ public Set<String> getPropertyNames() {
 
     @Override
     public String getValue(String propertyName) {
-        if (propertyName.equals(QUARKUS_BANNER_ENABLED)) {
-            return "false";
+        switch (propertyName) {
+            case (QUARKUS_BANNER_ENABLED) -> {
+                return "false";
+            }
+            case OTEL_METRICS_ENABLED -> {
+                return "true";
+            }
         }
         return null;
     }
 
     @Override
     public String getName() {
-        return "Quarkus Banner";
+        return "Quarkus Static Config Source";
     }
 }
diff --git a/...ent/src/main/resources/META-INF/services/org.eclipse.microprofile.config.spi.ConfigSource b/...ent/src/main/resources/META-INF/services/org.eclipse.microprofile.config.spi.ConfigSource
@@ -1 +1 @@
-xyz.block.ftl.deployment.BannerConfigSource
+xyz.block.ftl.deployment.StaticConfigSource
diff --git a/jvm-runtime/ftl-runtime/common/runtime/pom.xml b/jvm-runtime/ftl-runtime/common/runtime/pom.xml
@@ -24,6 +24,14 @@
             <groupId>io.quarkus</groupId>
             <artifactId>quarkus-rest-jackson</artifactId>
         </dependency>
+        <dependency>
+            <groupId>io.quarkus</groupId>
+            <artifactId>quarkus-opentelemetry</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>io.opentelemetry.instrumentation</groupId>
+            <artifactId>opentelemetry-jdbc</artifactId>
+        </dependency>
         <dependency>
             <groupId>com.fasterxml.jackson.module</groupId>
             <artifactId>jackson-module-kotlin</artifactId>

diff --git a/jvm-runtime/ftl-runtime/common/runtime/src/main/java/xyz/block/ftl/runtime/VerbHandler.java b/jvm-runtime/ftl-runtime/common/runtime/src/main/java/xyz/block/ftl/runtime/VerbHandler.java
@@ -1,8 +1,12 @@
 package xyz.block.ftl.runtime;
 
+import io.opentelemetry.api.common.AttributeKey;
+import io.opentelemetry.api.common.Attributes;
 import jakarta.inject.Singleton;
 
 import io.grpc.stub.StreamObserver;
+import io.opentelemetry.api.metrics.LongCounter;
+import io.opentelemetry.api.metrics.Meter;
 import io.quarkus.grpc.GrpcService;
 import xyz.block.ftl.v1.*;
 
@@ -11,14 +15,21 @@
 public class VerbHandler extends VerbServiceGrpc.VerbServiceImplBase {
 
     final VerbRegistry registry;
+    final LongCounter counter;
 
-    public VerbHandler(VerbRegistry registry) {
+    public VerbHandler(VerbRegistry registry, Meter meter) {
         this.registry = registry;
+        counter = meter.counterBuilder("ftl-jvm-runtime/verb_invocations")
+                .setDescription("The number of verb invocations")
+                .setUnit("invocations")
+                .build();
     }
 
     @Override
     public void call(CallRequest request, StreamObserver<CallResponse> responseObserver) {
         try {
+            counter.add(1, Attributes.of(AttributeKey.stringKey("module"), request.getVerb().getModule(), AttributeKey.stringKey("name"), request.getVerb().getName()));
+
             var response = registry.invoke(request);
             responseObserver.onNext(response);
             responseObserver.onCompleted();