PaginationCursor update from dwn-sdk-js
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiranCohen
force-pushed
the
lirancohen/pagination-cursor
branch
from
3c0aa66
to
359f05a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 80.41% 80.64% +0.23%
==========================================
Files 10 10
Lines 1072 1080 +8
Branches 152 149 -3
==========================================
+ Hits 862 871 +9
+ Misses 210 209 -1 |
LiranCohen
requested review from
amika-sq,
mistermoe and
thehenrytsai
as code owners
amika-sq
approved these changes
Jan 19, 2024
src/message-store-sql.ts
Outdated
Comment on lines
203
to
205
| // currently the sort property is explicitly either `dateCreated` | `messageTimestamp` | `datePublished` which are all strings | ||
| // if it is not of type string we return an empty result set | ||
| const cursorValue = pagination.cursor.value as string; |
There was a problem hiding this comment.
Just wanted to double check if this comment is still valid. I'm not immediately seeing an empty result set return if values isn't a string here.
There was a problem hiding this comment.
Good catch! I had some logic here but decided against it for now.
It's not a scenario that would really happen, and I'd like to add some DWN specific error to handle that case.
Created an issue and updated the comment to reflect.
TBD54566975/dwn-sdk-js#664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaginationCursoris a new object indwn-sdk-js.It is comprised of a
messageCidand avalue. Thevalueis of the sort property that you would like to continue your pagination from. ThemessageCidis used as a tiebreaker in the same way that query pagination already does.