Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improve test coverage 1 #818

Merged

Conversation

ANIRUDH-333
Copy link
Contributor

Resolves #136
Improves the test coverage in blockstore-mock.ts from 51.25% to 85%

File Name Statements Branches Functions Lines
Before:
All files 99.05 97.55 96.04 99.05
blockstore-mock.ts 51.25 100 8.33 51.25
After:
All files 99.29 97.57 97.7 99.29
blockstore-mock.ts 85 100 75 85

@ANIRUDH-333
Copy link
Contributor Author

This was a big change and took significant time. Would this qualify as Large change as per this?

@ANIRUDH-333
Copy link
Contributor Author

Hii @mistermoe , @csuwildcat , @thehenrytsai , @LiranCohen. Could you please review this?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (8b6eb13) to head (4622c9c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
+ Coverage   98.71%   98.95%   +0.23%     
==========================================
  Files          74       74              
  Lines       11469    11508      +39     
  Branches     1652     1672      +20     
==========================================
+ Hits        11322    11388      +66     
+ Misses        141      114      -27     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🚀

@thehenrytsai thehenrytsai merged commit 0a043f2 into TBD54566975:main Oct 9, 2024
4 checks passed
@thehenrytsai thehenrytsai added hacktoberfest For the hacking month of October hacktoberfest-accepted Accepted PRs for the hacking month of October small labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest For the hacking month of October hacktoberfest-accepted Accepted PRs for the hacking month of October small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase code coverage (even if just by a little bit)
3 participants