-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/WP-729: Mutation hook: Move files #996
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
==========================================
- Coverage 72.85% 72.68% -0.17%
==========================================
Files 534 534
Lines 33581 33657 +76
Branches 2988 2989 +1
==========================================
Hits 24464 24464
- Misses 8919 8995 +76
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on these! As a part of this task, should sagas be removed as well? Thoughts @jarosenb ?
Co-authored-by: Sal Tijerina <[email protected]>
Adding closing dispatch calls at the end Co-authored-by: Sal Tijerina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I also agree to the suggestion to remove the console log mentioned in #996 (comment) by @rstijerina
Works as intended on my end!
Overview
We are working on updating our current mutations to utilize TypeScript and React Query instead of React Redux. This should improve the speed and functionality of all portal systems going forward.
Related
Changes
I converted
useMove.js
touseMove.ts
and created a mutation that moves one or more files to a new location by updating its path.Testing
UI
Notes