Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/WP-276: Fixed Data Files Add button dropdown off-centered UI #863

Merged

Conversation

asimregmi
Copy link
Contributor

Overview

The triangle bit of the Data Files Add menu dropdown is not centered. This fix makes the dropdown centered and also makes the "Add" button centered.

Related

Changes

  • Changed width of Add button
  • Added margin to the drop down menu before and after it is clicked

Testing

  1. Navigate to portal > Data Files > Add button
  2. Check if the "Add" button and dropdown triangle is centered

UI

Desktop Display
iPhone XR Display

Notes

@asimregmi asimregmi marked this pull request as ready for review September 22, 2023 16:21
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #863 (5c22866) into main (033f8a6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #863   +/-   ##
=======================================
  Coverage   62.99%   62.99%           
=======================================
  Files         427      427           
  Lines       12188    12188           
  Branches     2504     2504           
=======================================
  Hits         7678     7678           
  Misses       4303     4303           
  Partials      207      207           
Flag Coverage Δ
javascript 68.71% <ø> (ø)
unittests 57.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@asimregmi asimregmi changed the title Fixed Data Files Add button dropdown off-centered UI Bug/WP-276: Fixed Data Files Add button dropdown off-centered UI Sep 22, 2023
Copy link
Collaborator

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@shayanaijaz shayanaijaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandra-tacc chandra-tacc merged commit 0835287 into main Sep 29, 2023
6 checks passed
@chandra-tacc chandra-tacc deleted the Bug/WP-276-Data-Files-Add-Menu-Tiny-Triangle-Off-Center branch September 29, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants