task/WP-189 Handle timeout exit code for interactive app jobs #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #851 +/- ##
==========================================
- Coverage 63.05% 63.05% -0.01%
==========================================
Files 425 426 +1
Lines 12112 12133 +21
Branches 2475 2479 +4
==========================================
+ Hits 7637 7650 +13
- Misses 4275 4279 +4
- Partials 200 204 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shayanaijaz
requested review from
rstijerina,
sophia-massie and
edmondsgarrett
chandra-tacc
pushed a commit
that referenced
this pull request
Sep 13, 2023
* added success message and state for interactive job on timeout * linting * created a central utility function, added logic to determine timeout * remove commented code * Added a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes an issue where after timing out an interactive job is displayed as FAILED when in fact the job was successful and should have the FINISHED state because it timed out after reaching the maximum allotted time.
Related
Changes
The changes implemented here are on the portal side where a check is made to confirm if the job is interactive and whether or not it ended because of a timeout. On the tapis side the job state remains
FAILEDbut we are able to use the exit code provided in theremoteResultInfoattribute of a job to determine if it was a timeout and display a success message on the portal side. This change is made inJobsViewandJobsWebhookViewendpointsTesting
FINISHEDstate after reaching the maximum runtime limitUI
Notes
Follow up question: Does the last status message displayed in the job detail modal need to be modified as well? Currently it shows the timeout error message sent from Tapis