POC: For Style Plugin, Support Automatic Tag #432
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Intelligently choose HTML tag for user choice of class (for example, in Django Style).
Tickets
<section>
tag for Sections created via:Changes
To our default
settings
:preferred_tag_for_class
template tag.DJANGOCMS_STYLE_TAGS_DEFAULT
(custom setting).div
)DJANGOCMS_STYLE_TAGS
(docs).DJANGOCMS_STYLE_TAGS_DEFAULT
New files:
djangocms-style
template.preferred_tag_for_class
template tagpreferred_tag_for_class
template tag.Screenshots
(pending)
Testing
div
, CLASS NAME---------
.<div>
.div
, CLASS NAMEo-section o-section--style-light
.<section>
.div
, CLASS NAMEo-section o-section--style-dark
.<section>
.div
, CLASS NAMEc-callout
.<aside>
.div
, CLASS NAMEc-recognition c-recognition--style-light
.<aside>
.div
, CLASS NAMEc-recognition c-recognition--style-dark
.<aside>
.article
, CLASS NAMEo-section o-section--style-light
.<article>
.article
, CLASS NAMEo-section o-section--style-dark
.<article>
.article
, CLASS NAMEc-callout
.<article>
.article
, CLASS NAMEc-recognition c-recognition--style-light
.<article>
.article
, CLASS NAMEc-recognition c-recognition--style-dark
.<article>
.