Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(folders): move folder for clarity #473

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Conversation

DanielHabenicht
Copy link
Collaborator

closes #430

@DanielHabenicht
Copy link
Collaborator Author

Should we also rename source to dataSource?

@paule96 should I adhere to the standard of the .net Project and make it Demo.Assets and so on?

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-473.demo-phonebook.me

@paule96
Copy link
Collaborator

paule96 commented Jan 12, 2020

first I would create a src folder for Phonebook.Frontend and Phonebook.Source.PeopleSoft.

also I would rename the folder Phonebook to scripts or hostingor something like this. Because there is all the operational stuff in it.

But this is maybe another issue. This is currently only for demo. So we should only look at demo. To this I will create an issue if it not exsists already.

@paule96
Copy link
Collaborator

paule96 commented Jan 12, 2020

Should we also rename source to dataSource?
@paule96 should I adhere to the standard of the .net Project and make it Demo.Assets and so on?

no not in this PR. the issue was explicit only for demo.

@DanielHabenicht
Copy link
Collaborator Author

DanielHabenicht commented Jan 12, 2020

first I would create a src folder for Phonebook.Frontend and Phonebook.Source.PeopleSoft.

Ok I will go forward and create a src folder

also I would rename the folder Phonebook to scripts or hostingor something like this. Because there is all the operational stuff in it.

Yep, how about helm?

But this is maybe another issue. This is currently only for demo. So we should only look at demo. To this I will create an issue if it not exsists already.

I would like to do it here. No need for another issue

@paule96
Copy link
Collaborator

paule96 commented Jan 12, 2020

first I would create a src folder for Phonebook.Frontend and Phonebook.Source.PeopleSoft.

Ok I will go forward and create a src folder

also I would rename the folder Phonebook to scripts or hostingor something like this. Because there is all the operational stuff in it.

Yep, how about helm?

But this is maybe another issue. This is currently only for demo. So we should only look at demo. To this I will create an issue if it not exsists already.

helm is a product name. not a thing you can do or understand. So it isn't a good name. You describe what the folder contains or what you can do with it. Not what product you must install to use it 🤷‍♀️

@DanielHabenicht
Copy link
Collaborator Author

first I would create a src folder for Phonebook.Frontend and Phonebook.Source.PeopleSoft.
Ok I will go forward and create a src folder
also I would rename the folder Phonebook to scripts or hostingor something like this. Because there is all the operational stuff in it.
Yep, how about helm?
But this is maybe another issue. This is currently only for demo. So we should only look at demo. To this I will create an issue if it not exsists already.

helm is a product name. not a thing you can do or understand. So it isn't a good name. You describe what the folder contains or what you can do with it. Not what product you must install to use it 🤷‍♀️

helm-chart then?

@paule96
Copy link
Collaborator

paule96 commented Jan 12, 2020

first I would create a src folder for Phonebook.Frontend and Phonebook.Source.PeopleSoft.
Ok I will go forward and create a src folder
also I would rename the folder Phonebook to scripts or hostingor something like this. Because there is all the operational stuff in it.
Yep, how about helm?
But this is maybe another issue. This is currently only for demo. So we should only look at demo. To this I will create an issue if it not exsists already.

helm is a product name. not a thing you can do or understand. So it isn't a good name. You describe what the folder contains or what you can do with it. Not what product you must install to use it 🤷‍♀️

helm-chart then?

no. What does the folder do? or for what kind of people is it for. Think this way. not in product.
Helm chart, is the same like PowerShell script. that can do all and nothing. What does the stuff do. Maybe we call it install or so. Or setup. or operational

@DanielHabenicht
Copy link
Collaborator Author

Discussion of src folder is now here: #507

This PR is now only about moving the demo folders

@DanielHabenicht DanielHabenicht merged commit ed79a00 into master Mar 3, 2020
@mmsgithub-ci
Copy link
Collaborator

🎉 This PR is included in version 1.36.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@DanielHabenicht DanielHabenicht deleted the chore/430 branch April 12, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Naming and folders
4 participants