Add MemNode support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekPikula
requested changes
Apr 16, 2024
|
Two more things:
|
|
I've updated CHANGELOG and rebased onto the latest |
MarekPikula
approved these changes
Apr 16, 2024
Pull Request Test Coverage Report for Build 8708877033Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 8708877033Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 8710316940Details
💛 - Coveralls |
MarekPikula
requested changes
Apr 16, 2024
This commit adds support for PeakRDL MemNode objects. Register arrays inside MemNode are not being unrolled to keep memory description brief. Memories can hold hundreds or even more virtual registers and unrolling all of them is not beneficial and mudders the overall picture. Signed-off-by: Maciej Dudek <[email protected]>
|
Thanks again for the contribution. It's released now as 1.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for PeakRDL MemNode objects. Register arrays inside MemNode are not being unrolled to keep memory description brief.
Memories can hold hundreds or even more virtual registers and unrolling all of them is not beneficial and mudders the overall picture.
Solves #12