Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GPR curation for Inositol phosphate metabolism #905

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

JHL-452b
Copy link
Collaborator

@JHL-452b JHL-452b commented Nov 5, 2024

Main improvements in this PR:

As proposed in #862

  • Remove ENSG00000104331 from MAR06540;
  • Remove ENSG00000163082, ENSG00000125458, ENSG00000205309, ENSG00000054148 from MAR06545;
  • Remove ENSG00000163082, ENSG00000126821, ENSG00000125458, ENSG00000054148, ENSG00000205309, ENSG00000205808, ENSG00000163719, ENSG00000213920, ENSG00000003987, ENSG00000144048 from MAR06547;
  • Remove ENSG00000163082, ENSG00000126821, ENSG00000125458, ENSG00000054148, ENSG00000205309, ENSG00000163719, ENSG00000063601, ENSG00000165688, ENSG00000144048 from MAR06557;
  • Remove ENSG00000104331 from MAR06562;
  • Remove ENSG00000104331 from MAR06571;
  • Remove ENSG00000163082, ENSG00000126821, ENSG00000144048 from MAR06591;
  • Remove ENSG00000107242 from MAR06595;
  • Remove ENSG00000186111 from MAR08811.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link

github-actions bot commented Nov 5, 2024

This PR has been automatically tested with GH Actions. Here is the output of the MACAW test:

Starting dead-end test...
- Found 1514 dead-end metabolites.
- Found 1319 reactions incapable of sustaining steady-state fluxes in either direction due to these dead-ends.
- Found 1977 reversible reactions that can only carry steady-state fluxes in a single direction due to dead-ends.
Starting duplicate test...
- Skipping redox duplicates because no redox_pairs and/or proton_ids were provided.
- Found 447 reactions that were some type of duplicate:
- 0 were completely identical to at least one other reaction.
- 13 involve the same metabolites but go in the opposite direction or have the opposite reversibility as at least one other reaction.
- 447 involve the same metabolites but with different coefficients as at least one other reaction.

This and a more detailed output from MACAW are also committed to data/macawResults/.

Note: In the case of multiple test runs, this post will be edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant