-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Human 1.19 #823
Human 1.19 #823
Conversation
…ion. I don't think that code had ever been run, it was just not right.
…urrently only processes the model available in the repo, and does not compare with any older model version. The code is however prepared for comparing versions. Currently, it only processes 2 out of 40 chunks of data, this is to be changed when we want to run a full evaluation with 891 cell lines.
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Added metabolite SMILES and Inchi Information
…tsv into MAR06416/7 and MAR06419/20
…move TMEM91 from the model
…AR03151 + MAR03153
…AR03158 + MAR03160
…AR03166 + MAR03885
…0,51,53,56,57,58,60,63,64,66
…d 2-OADH reactions and thiamine-to-lipoyl transfer for 2-OADH
…hiamine-dependent steps
Fix Duplicate BCKDH Reactions
Remove MAR03422
…to_gprs fix: GPRs for mitochondrial 2-enoyl-CoA hydratase reactions
Remove Tagatose-1,6-Bisphosphate
Fix Stereochemistry of Phytanic Acid Oxidation
…actions fix: modified unbalance reactions
Fix Mitochondrial Thiamine Transport Reactions
chore: update actions
Thanks Ed for fixing the issue! |
There were two problems:
The latter could be resolved by a round of import-export. The resulting model could then be diff'ed, and the differences to The first problem could only be resolved by a To reduce the risk of similar problems in the future:
|
Updated essentiality evaluation using combined (
Compared with The organ-specific models were generated by the ftINIT (1+1 mode) , and the |
Hmm, and everything was done exactly the same for all of these versions? Would be good to figure out what makes the difference? Is it possible to do interval halving, i.e., include half of the changes and see if it changed then, then close in on the interval by taking/removing half of the changes where the change occured? For the Hart dataset this may not be that heavy? |
Actually the drop in FP is the biggest relative change; it seems overall to have improved a decent amount, though at the expense of a bit lower sensitivity - a good trade off in my opinion. |
I'm not sure what was done for previous versions. But we do need to figure out what's causing the difference.
Do you mean to try to impose half of changes to the model and evaluate it, if I understand correctly. This sounds like a good idea. @johan-gson |
Yep, and then depending on in which half the changes, split that in half and include all changes up to that point, and os on. Will give log(n) complexity :) |
Fantastic to have this merged! And indeed a positive (great!) suprise with the increase in the MCC. One could use also |
Main improvements in this PR:
Fixes(PR chore: update actions #818 )
Fixes(PR fix: modified unbalance reactions #816 )
Fixes(PR Fix Mitochondrial Thiamine Transport Reactions #815 )
ENSG00000125454
as GPR;ENSG00000125454
as GPR;ENSG00000125454
as GPR;Fixes(PR fix: standardize all names of exchange reactions #811)
Fixes(PR fix: GPRs for mitochondrial 2-enoyl-CoA hydratase reactions #808)
ENSG00000084754 or ENSG00000127884
(HADHA or ECHS1)Fixes(PR Remove Tagatose-1,6-Bisphosphate #807)
Fixes(PR Fix Stereochemistry of Phytanic Acid Oxidation #805)
MAM02746e, MAM02746c and MAM02746x
to "(3R)-phytanic acid" andMAM02747c and MAM02747x
to "(3R)-phytanoyl-CoA"Fixes(PR Remove MAR00965 and Fix GPR of MAR00970 #794)
Fixes(PR Merge Duplicate Mitochondrial Linoleic and Gamma-Linolenic Acid Beta-Oxidation Pathways #793 )
Fixes(PR Resolve Duplicate Phytanoyl-CoA Alpha-Oxidation Reactions #792)
Fixes(PR Remove EHHADH from the GPR of MAR03288 #790)
Fixes(PR Remove Duplicate Decanoyl-CoA to Octanoyl-CoA Beta-Oxidation Reactions #789)
Fixes(PR fix: revise rxns and GPRs associated with DECR1 and DECR2 #788)
Fixes(PR fix: remove genes only expressed in peroxisome from beta-oxidation reactions in mitochondria #770)
Fixes(PR Remove Duplicate Linolenoyl-CoA Beta-Oxidation Reactions #768)
Fixes(PR Fix GPRs for MAR03269 and MAR03380 #760)
ENSG00000084754 or ENSG00000072506
genes, as discussed in GPRs for Mitochondrial 3-Hydroxyacyl-CoA Oxidation Reactions #758Fixes(PR Fix inconsistent representation of thiamine and lipoic acid in 2-oxoacid dehydrogenase reactions #753)
ENSG00000105953 or ENSG00000181192
as GPRENSG00000248098 and ENSG00000083123
as GPRENSG00000248098 and ENSG00000083123
as GPRENSG00000248098 and ENSG00000083123
as GPRENSG00000248098 and ENSG00000083123
ENSG00000248098 and ENSG00000083123
as GPR and MAR20178 withENSG00000137992
as GPR.Fixes(PR Remove MAR03422 #752)
Fixes(PR Fix Duplicate Octanoyl-CoA Beta-Oxidation Reactions #751)
Fixes(PR Fix BCKDH Genes and Remove Mito & Nuc Thiocyanate <-> Hypothiocyanite Reactions #750)
Fixes(PR Fix Duplicate BCKDH Reactions #743)
Features (PR Feat: added smiles and inchi of metabolites #731)
Feature(PR feat: add gene essentiality check using DepMap #574)