Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: merge "Heme biosynthesis" subsystem into "Porphyrin metabolism" #703

Merged
merged 1 commit into from
Oct 7, 2023
Merged

style: merge "Heme biosynthesis" subsystem into "Porphyrin metabolism" #703

merged 1 commit into from
Oct 7, 2023

Conversation

haowang-bioinfo
Copy link
Member

@haowang-bioinfo haowang-bioinfo commented Oct 5, 2023 •
edited
Loading

Main improvements in this PR:

This PR merges "Heme biosynthesis" subsystem into "Porphyrin metabolism" subsystem, to address issues raised in #356 and #681, by:

  • change "Heme biosynthesis" subsystem to "Porphyrin metabolism" for reactions MAR01643, MAR11316, and MAR11406
  • remove "Heme biosynthesis" subsystem from reaction MAR01044

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@feiranl feiranl self-requested a review October 7, 2023 11:44
feiranl
feiranl approved these changes Oct 7, 2023
View reviewed changes
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feiranl feiranl merged commit 0c8bdd1 into develop Oct 7, 2023
8 checks passed
@haowang-bioinfo haowang-bioinfo deleted the mergeMultiSubsystems branch October 8, 2023 19:04
This was referenced Oct 8, 2023
Closed
Closed
@haowang-bioinfo haowang-bioinfo mentioned this pull request Dec 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiranl feiranl feiranl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haowang-bioinfo @feiranl