Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PPARA Reactions #678

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Remove PPARA Reactions #678

merged 4 commits into from
Aug 1, 2023

Conversation

Devlin-Moyer
Copy link
Collaborator

@Devlin-Moyer Devlin-Moyer commented Jul 16, 2023

Main improvements in this PR:

As discussed in the comments on #580, removes all reactions involving MAM01268 or MAM02757 in all compartments:

  • MAR00024
  • MAR00025
  • MAR00026
  • MAR00027
  • MAR00028
  • MAR00029
  • MAR05173
  • MAR05289
  • MAR13064

Also removes all metabolites that only participated in those reactions:

  • MAM01816n
  • MAM01268c
  • MAM01268e
  • MAM01268m
  • MAM01268n
  • MAM01268r
  • MAM01268x
  • MAM02757c
  • MAM02757l
  • MAM02757n

Also removes all genes that only participated in one or more of these reactions:

  • ENSG00000069667
  • ENSG00000101849
  • ENSG00000118137
  • ENSG00000126368
  • ENSG00000135744
  • ENSG00000137574
  • ENSG00000139278
  • ENSG00000140396
  • ENSG00000141027
  • ENSG00000142453
  • ENSG00000143344
  • ENSG00000158874
  • ENSG00000166821
  • ENSG00000167772
  • ENSG00000169375
  • ENSG00000170485
  • ENSG00000171720
  • ENSG00000177565
  • ENSG00000186350
  • ENSG00000186951
  • ENSG00000196498
  • ENSG00000198646

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@Devlin-Moyer
Copy link
Collaborator Author

Apparently MAR00024 was the only reaction that MAM01816n participated in, so I'm also going to remove that

@haowang-bioinfo
Copy link
Member

this is a natural follow-up implementation to the discussion in #580 - nice work @Devlin-Moyer

if to remove all reactions involving MAM01268, should MAR00030 be also be removed?

@Devlin-Moyer
Copy link
Collaborator Author

MAR00030 was removed by #657

Copy link
Member

@haowang-bioinfo haowang-bioinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these removed genes are mostly annotated with regulatory function. In particular, ENSG00000137574 and ENSG00000142453 are assigned with methyltransferase activity. Still they don't appear to be involved into any metabolic process.

it's okay to remove the genes in my view, and they can be added later once concrete evidence is provided

@haowang-bioinfo haowang-bioinfo merged commit 5896d8c into develop Aug 1, 2023
8 checks passed
@haowang-bioinfo haowang-bioinfo deleted the fix/remove_ppara_rxns branch August 1, 2023 09:26
@haowang-bioinfo haowang-bioinfo mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants